Repository navigation
[No QA]Run npm install before building each build - #13374
Conversation
|
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Again ignoring puller bear and giving to @luacmartins for context. |
luacmartins
left a comment
There was a problem hiding this comment.
LGTM! Just checking that we are adding it twice because we want it to run in both the compare and baseline commits?
|
Yes - We actually end up running it three times. We run it once when the workflow boots in |
Reviewer Checklist
N/A since this only affects GH actions. Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀
|
Details
We are now seeing failed builds because the build is using newer dependencies than it should, failing the build. This adds a
npm cito each build phase to verify the node packages are correct for each build.Fixed Issues
Fixes broken build: https://github.com/Expensify/App/actions/runs/3632291167/jobs/6127971085
Tests
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android